-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fillDescriptions to EmptyIOVSource #25794
Conversation
The base class added a new optional parameter. Providing a fillDescriptions will automatically deal with the change.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25794/8229
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: CondCore/Utilities @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
This fixes the unit test failures in the IBs |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@ggovi this is a fix for an issue affecting unit tests in IB, could you please check and sign it? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
The base class added a new optional parameter. Providing a fillDescriptions will automatically deal with the change.