-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SwitchProducer sanity checks to allow more than one SwitchProducer in a job. #25801
Conversation
The code-checks are being triggered in jenkins. |
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25801/8235
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
The check for non-chosen cases to declare exactly the same products was flawed in a way preventing the job to have more than one SwitchProducers. In more detail, the check complained that the cases of SwitchProducer
foo
did not declare products of SwitchProducerbar
. This PR fixes the check by limiting the check to limit the products-to-be-checked to a singleSwitchProducer
.Tested in 10_5_0_pre1.