Manage PluginFactory plugin with unique_ptr in ExternalDecayDriver #25825
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25825/8266
|
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: GeneratorInterface/ExternalDecays @alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
| if ( fPhotosInterface ) delete fPhotosInterface; | ||
| } | ||
|
|
||
| ExternalDecayDriver::~ExternalDecayDriver() = default; |
There was a problem hiding this comment.
@makortel in principle this could just be declared in the header at this point? Anyway ok for me
There was a problem hiding this comment.
Only moving the destructor definition to header would not be enough as also the includes of TauolaInterfaceBase.h etc would have to be moved (in order for the compiler to generate the call to their destructor). That in turn might increase physical coupling of the clients of ExternalDecayDriver to the decayers.
|
+1 |
This PR is preparatory work to change the PluginFactory to return a
std::unique_ptr.Tested in CMSSW_10_5_X_2019-01-23-1100, no changes expected.