Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize dictionary generation in SimDataFormats #25829

Merged
merged 2 commits into from
Feb 7, 2019

Conversation

Dr15Jones
Copy link
Contributor

-removed the use of the struct dictionary
-removed usage of pattern from classes_def.xml

This should aid in transitioning to ROOT's new module system.

ROOT no longer requires forcing the instantiation of templates
in the .h file. The declaration in classes_def.xml is sufficient.
-removed unneeded struct dictionary
-removed use of pattern in classes_def.xml
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25829/8272

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

SimDataFormats/CaloHit
SimDataFormats/CaloTest
SimDataFormats/CrossingFrame
SimDataFormats/DigiSimLinks
SimDataFormats/EcalTestBeam
SimDataFormats/EncodedEventId
SimDataFormats/Forward
SimDataFormats/GEMDigiSimLink
SimDataFormats/GeneratorProducts
SimDataFormats/HTXS
SimDataFormats/HcalTestBeam
SimDataFormats/HiGenData
SimDataFormats/JetMatching
SimDataFormats/PileupSummaryInfo
SimDataFormats/RPCDigiSimLink
SimDataFormats/RandomEngine
SimDataFormats/Track
SimDataFormats/TrackerDigiSimLink
SimDataFormats/TrackingAnalysis
SimDataFormats/TrackingHit
SimDataFormats/ValidationFormats
SimDataFormats/Vertex

@efeyazgan, @perrozzi, @civanch, @kpedro88, @cmsbuild, @mdhildreth, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@pvmulder, @imarches, @makortel, @smoortga, @acaudron, @abbiendi, @rovere, @argiro, @HeinerTholen, @JyothsnaKomaragiri, @mverzett, @HuguesBrun, @wddgit, @jhgoh, @calderona, @ferencek, @battibass, @ebrondol, @trocino, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32944/console Started: 2019/01/31 22:21

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25829/32944/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@civanch
Copy link
Contributor

civanch commented Feb 1, 2019

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Feb 2, 2019

+upgrade

@fabiocos
Copy link
Contributor

fabiocos commented Feb 6, 2019

@qliphy @efeyazgan @alberto-sanchez do you have any objection or can we move forward with this technical update?

@alberto-sanchez
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Feb 7, 2019

+1

@cmsbuild cmsbuild merged commit dacbab8 into cms-sw:master Feb 7, 2019
@Dr15Jones Dr15Jones deleted the removeDictionarySimDataFormats branch February 7, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants