-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize dictionary generation in SimDataFormats #25829
Modernize dictionary generation in SimDataFormats #25829
Conversation
ROOT no longer requires forcing the instantiation of templates in the .h file. The declaration in classes_def.xml is sufficient.
-removed unneeded struct dictionary -removed use of pattern in classes_def.xml
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25829/8272
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: SimDataFormats/CaloHit @efeyazgan, @perrozzi, @civanch, @kpedro88, @cmsbuild, @mdhildreth, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+upgrade |
@qliphy @efeyazgan @alberto-sanchez do you have any objection or can we move forward with this technical update? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
-removed the use of the struct dictionary
-removed usage of pattern from classes_def.xml
This should aid in transitioning to ROOT's new module system.