Use fixed order vector instead of map in EventSetup #25896
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25896/8367
|
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
| recordMap_[iKey]= iRecord; | ||
| auto lb = std::lower_bound(keysBegin_, keysEnd_, iKey); | ||
| if (lb == keysEnd_ || iKey != *lb) { | ||
| throw cms::Exception("LogicError") << "EventSetupImpl::insert Could not find key\n" |
There was a problem hiding this comment.
this error message would be more helpful if it included:
- information about the key (name, ?)
- information about what was found instead (another key, or nothing)
There was a problem hiding this comment.
I believe the exception can only happen if there is a messup in the framework code. As such, if it happens the framework group would have to diagnose the problem anyway.
There was a problem hiding this comment.
Okay, if I ever encounter this in the future, I will just forward it to you...
| std::shared_ptr<EventSetupRecordProvider>& EventSetupProvider::recordProvider(const EventSetupRecordKey& iKey) { | ||
| auto lb = std::lower_bound(recordKeys_.begin(), recordKeys_.end(), iKey); | ||
| if (lb == recordKeys_.end() || iKey != *lb) { | ||
| throw cms::Exception("LogicError") << "EventSetupProvider::recordProvider Could not find key\n" |
|
@kpedro88 I’m waiting on this change because I’m also working on these same files and need this change for my work. |
|
+1 |
No description provided.