Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch hierarchyconstraints to CMSSW_7_0_X #2591

Merged
merged 1 commit into from Mar 14, 2014

Conversation

frmeier
Copy link
Contributor

@frmeier frmeier commented Feb 21, 2014

This is a backport to 70X of pull request #2370. Notes from there:

This patch has been prepared by Gero Flucke some time ago, see https://twiki.cern.ch/twiki/bin/viewauth/CMS/TkAlignmentLegacyThoughts, first topic. Testing happened on CMSSW_4_4_5. Results were presented in the alignment meeting of Oct 31, 2013, where the modifications got blessed. See https://twiki.cern.ch/twiki/bin/viewauth/CMS/TkAlPullReq201401 for more details and link to the presentation.
This is an outstanding issue since months that was not put into git.

For consistency, this needs to be put into earlier releases as well. Please give instructions if this is not the right flavour of 70X and/or if we should target this patch to other 70X versions as well.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @frmeier (Frank Meier) for CMSSW_7_0_X.

Patch hierarchyconstraints to CMSSW_7_0_X

It involves the following packages:

Alignment/CommonAlignmentParametrization

@cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @mmusich this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@frmeier
Copy link
Contributor Author

frmeier commented Feb 21, 2014

I would like to add the following:
When I compiled this in 70X I received the same warning as was mentioned in https://hypernews.cern.ch/HyperNews/CMS/get/sw-develtools/1962/1.html. I'm assuming this is ok in this case as well. Maybe you want to do what was proposed in that hn thread.

@cmsbuild
Copy link
Contributor

@rcastello
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@davidlange6
Copy link
Contributor

+1

nclopezo added a commit that referenced this pull request Mar 14, 2014
Alignment/CommonAlignmentParametrization -- Patch hierarchyconstraints to CMSSW_7_0_X
@nclopezo nclopezo merged commit ede08db into cms-sw:CMSSW_7_0_X Mar 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants