-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use unique_ptr constructor for PluginFactory plugins in RecoPixelVertexing #25956
Use unique_ptr constructor for PluginFactory plugins in RecoPixelVertexing #25956
Conversation
…exing/PixelTriplets This works for PluginFactory returning either raw pointer or unique_ptr.
…itTripletProducer
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25956/8452
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: RecoPixelVertexing/PixelTriplets @cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@makortel : there is a potential memory leak pointed out by the static analyzer, which does not depend on your changes but you can maybe profit of this PR and fix: I think that it could be enough moving up the three lines 69-71 right after L60, so that the check is performed before thirdHitMap is created from Please let me know if you plan to fix it here, otherwise I'll prepare another PR with it |
The issue with the potential memory leak is addressed in #25963: no reason to keep this pull request further in standby |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Also manage a plugin with unique_ptr and cleanup further
HitTripletProducer
.This PR is preparatory work to change the PluginFactory to return a
std::unique_ptr
.Tested in CMSSW_10_5_X_2019-02-05-1100 , no changes expected.