Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: FWHGCRecHitProxyBuilder #26058

Merged
merged 2 commits into from Mar 5, 2019
Merged

Fix: FWHGCRecHitProxyBuilder #26058

merged 2 commits into from Mar 5, 2019

Conversation

Mourtz
Copy link
Contributor

@Mourtz Mourtz commented Mar 4, 2019

HGCRecHitProxy now renders the rechits with the correct geometry.
Also added Layer, Heatmap and Endcap selector.

@rovere

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26058/8612

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2019

A new Pull Request was created by @Mourtz (Alex Mourtziapis) for master.

It involves the following packages:

Fireworks/Calo

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26058/8620

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

Pull request #26058 was updated. @cmsbuild, @alja, @Dr15Jones can you please check and sign again.

@fabiocos
Copy link
Contributor

fabiocos commented Mar 5, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33406/console Started: 2019/03/05 11:47

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@alja
Copy link
Contributor

alja commented Mar 5, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 5, 2019

+1

@cmsbuild cmsbuild merged commit 0c4a829 into cms-sw:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants