New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using ROOT's Transform3D #26073
Switch to using ROOT's Transform3D #26073
Conversation
The ROOT::Math::Transform3D has had all the optimizations present in Transform3DPJ since 2008.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26073/8631
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: RecoEgamma/EgammaTools @cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@fabiocos this will clear up the majority of 'dependency violations' flagged in the IB builds. |
@Dr15Jones I'll pick it for next IB, thanks for the comment |
+1 |
The ROOT::Math::Transform3D has had all the optimizations present in Transform3DPJ since 2008.