Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using ROOT's Transform3D #26073

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Dr15Jones
Copy link
Contributor

The ROOT::Math::Transform3D has had all the optimizations present in Transform3DPJ since 2008.

The ROOT::Math::Transform3D has had all the optimizations present
in Transform3DPJ since 2008.
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26073/8631

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

RecoEgamma/EgammaTools

@cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks.
@jainshilpi, @Sam-Harper, @varuns23, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33416/console Started: 2019/03/05 17:27

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26073/33416/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3114826
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3114628
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@slava77
Copy link
Contributor

slava77 commented Mar 6, 2019

+1

for #26073 50a2134

  • technical
  • jenkins tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@Dr15Jones
Copy link
Contributor Author

@fabiocos this will clear up the majority of 'dependency violations' flagged in the IB builds.

@fabiocos
Copy link
Contributor

fabiocos commented Mar 7, 2019

@Dr15Jones I'll pick it for next IB, thanks for the comment

@fabiocos
Copy link
Contributor

fabiocos commented Mar 7, 2019

+1

@cmsbuild cmsbuild merged commit 2751089 into cms-sw:master Mar 7, 2019
@Dr15Jones Dr15Jones deleted the dropTrasnform3DPJEgammaPCAHelper branch March 15, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants