Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ; to all ClassImp expressions #26091

Merged
merged 1 commit into from Mar 7, 2019
Merged

Conversation

davidlange6
Copy link
Contributor

Make consistent with root and make clang-format happy

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26091/8657

  • This PR adds an extra 508KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2019

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

Alignment/CocoaDaq
Alignment/CocoaFit
Alignment/MillePedeAlignmentAlgorithm
CalibCalorimetry/EcalCorrelatedNoiseAnalysisAlgos
CalibCalorimetry/EcalLaserAnalyzer
DataFormats/HeavyIonEvent
Fireworks/Core
Fireworks/TableWidget
IOPool/TFileAdaptor
IORawData/HcalTBInputService
MuonAnalysis/MomentumScaleCalibration
PhysicsTools/RooStatsCms
PhysicsTools/TagAndProbe
RecoVertex/BeamSpotProducer
SimMuon/Neutron
SimTransport/TotemRPProtonTransportParametrization
TrackingTools/TrackAssociator

@perrotta, @smuzaffar, @civanch, @Dr15Jones, @tocheng, @cmsbuild, @alja, @franzoni, @mdhildreth, @slava77, @pohsun, @santocch can you please review it and eventually sign? Thanks.
@yslai, @felicepantaleo, @abbiendi, @argiro, @tlampen, @mmusich, @calderona, @makortel, @jhgoh, @HuguesBrun, @drkovalskyi, @ptcox, @trocino, @yetkinyilmaz, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @tocheng, @mschrode, @ebrondol, @dgulhan, @adewit, @mandrenguyen, @battibass, @wddgit, @alja, @gpetruc, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

+core

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33442/console Started: 2019/03/06 17:58

@civanch
Copy link
Contributor

civanch commented Mar 6, 2019

+1

@alja
Copy link
Contributor

alja commented Mar 6, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26091/33442/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3114826
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3114628
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Mar 6, 2019

+1

  • Technical, trivial
  • Jenkins tests pass

@tocheng
Copy link
Contributor

tocheng commented Mar 6, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Mar 7, 2019

+1

technical migration

@fabiocos
Copy link
Contributor

fabiocos commented Mar 7, 2019

merge

@cmsbuild cmsbuild merged commit 6959115 into cms-sw:master Mar 7, 2019
@santocch
Copy link

santocch commented Mar 7, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants