New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Rivet weights #26111
Fix Rivet weights #26111
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26111/8679
|
A new Pull Request was created by @intrepid42 (Markus Seidel) for master. It involves the following packages: GeneratorInterface/RivetInterface @alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Fix combination of GenEventInfoProduct and LHEEventProduct weights to be passed to Rivet analysis, now agrees with instructions in the twiki: https://twiki.cern.ch/twiki/bin/viewauth/CMS/LHEReaderCMSSW
Thanks to Alexander for spotting the problem: https://hypernews.cern.ch/HyperNews/CMS/get/generators/4273.html
NB: This will require a larger rewrite when Rivet becomes capable of handling multiple weights at once.
PR validation:
By mistake, combined PS+LHE weights became positive (blue) also for events that should have a negative overall weight. The fixed version (green) agrees with the default positive/negative ratio (red).