Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VtxSmearingScenario for 10_6_X MC production - Round Optics #26140

Merged

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented Mar 11, 2019

Update the VtxSmearingScenario parameters for 10_6_X MC production.
Two different configurations are created to test the possible beamspot conditions during Run3 using round optics.
The same BeamSpot (run 316199, fill 6675) and Barycenter (from Payload Inspector https://cms-conddb.cern.ch/cmsDbBrowser/payload_inspector/Prod ) positions are used in both configurations.
The two configurations only differ by the sigmaZ:

  1. LowSigmaZ --> sigmaZ = 3.4 cm
  2. HighSigmaZ --> sigma> = 5.7 cm

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26140/8709

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

Configuration/PyReleaseValidation
Configuration/StandardSequences
IOMC/EventVertexGenerators

@pgunnell, @prebello, @zhenhu, @civanch, @kpedro88, @cmsbuild, @franzoni, @mdhildreth, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor

@francescobrivio
Maybe you can change the subject and description, as current master is 10_6.

Is backport needed?

@francescobrivio francescobrivio changed the title Update VtxSmearingScenario for 10_5_X MC production - Round Optics Update VtxSmearingScenario for 10_6_X MC production - Round Optics Mar 11, 2019
@francescobrivio
Copy link
Contributor Author

@srimanob
Subject and description changed.
A backport is not needed.

@mtosi
Copy link
Contributor

mtosi commented Mar 11, 2019

ciao
apologies for this low level question, but this PR is introducing changes in a file I was not expecting
it is
Configuration/PyReleaseValidation/python/relval_steps.py

in addition, I see the commnet on the missing new line at the end of file for both
IOMC/EventVertexGenerators/python/VtxSmearedRun3RoundOptics25ns13TeVHighSigmaZ_cfi.py
and
IOMC/EventVertexGenerators/python/VtxSmearedRun3RoundOptics25ns13TeVLowSigmaZ_cfi.py

@kpedro88
Copy link
Contributor

Base branch for this PR is 10_5, needs to be rebased to 10_6

@prebello
Copy link
Contributor

@mtosi maybe @fabiocos can explain why my commits on relval_step from 24 days ago is appearing in this PR :-)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@francescobrivio
Copy link
Contributor Author

As suggested, I rebased to 10_6

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26140/8721

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #26140 was updated. @civanch, @mdhildreth, @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please check and sign again.

@mtosi
Copy link
Contributor

mtosi commented Mar 11, 2019

as expected, the rebase fixed the file I pointed in my previous comment ;) thanks

@civanch
Copy link
Contributor

civanch commented Mar 12, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33547/console Started: 2019/03/12 17:29

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26140/33547/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3114829
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3114631
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

+operations

the update of StandardSequences is coherent with the purpose of the PR

@civanch
Copy link
Contributor

civanch commented Mar 13, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants