Interface for external Pyquen #4790 #26226

wouf · 2019-03-20T19:24:39Z

Interface for Pyquen as external generator. Should be merged together with cms-sw/cmsdist#4790

cmsbuild · 2019-03-20T19:25:10Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-03-20T19:31:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26226/8849

This PR adds an extra 20KB to repository

cmsbuild · 2019-03-20T19:31:39Z

A new Pull Request was created by @wouf for master.

It involves the following packages:

GeneratorInterface/PyquenInterface

@alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @cbaus, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

wouf · 2019-03-21T09:45:46Z

I mean that this PR should be merged simultaneously with cms-sw/cmsdist#4790

davidlange6 · 2019-03-21T12:06:04Z

why does cmssw itself need pyquen.F?

…

On Mar 21, 2019, at 5:45 AM, wouf ***@***.***> wrote: I mean that this PR should be merged simultaneously with cms-sw/cmsdist#4790 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

wouf · 2019-03-21T12:43:26Z

We needn't it anymore. I replace it with external one. I deleted pyquen.F, HepEvt.F and hepevt.inc files in this interface changes.

why does cmssw itself need pyquen.F?
…
On Mar 21, 2019, at 5:45 AM, wouf @.***> wrote: I mean that this PR should be merged simultaneously with cms-sw/cmsdist#4790 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

davidlange6 · 2019-03-21T13:06:32Z

so you'll update the PR?

…

On Mar 21, 2019, at 8:43 AM, wouf ***@***.***> wrote: We needn't it anymore. I replace it with external one. I deleted pyquen.F, HepEvt.F and hepevt.inc files in this interface changes. why does cmssw itself need pyquen.F? … On Mar 21, 2019, at 5:45 AM, wouf ***@***.***> wrote: I mean that this PR should be merged simultaneously with cms-sw/cmsdist#4790 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

wouf · 2019-03-21T13:14:59Z

For why? Don't understand Your point. In this PR 10 files was changed, including 3 deletion. Отправлено с Redmi 4X David Lange <notifications@github.com> | От: 21 мар. 2019 г. 4:07 ПП | Сообщение: so you'll update the PR?

On Mar 21, 2019, at 8:43 AM, wouf ***@***.***> wrote: We needn't it anymore. I replace it with external one. I deleted pyquen.F, HepEvt.F and hepevt.inc files in this interface changes. why does cmssw itself need pyquen.F? … On Mar 21, 2019, at 5:45 AM, wouf ***@***.***> wrote: I mean that this PR should be merged simultaneously with cms-sw/cmsdist#4790 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#26226 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGIfJNS7VzkORj7sTBZOBUg0xw77_FcPks5vY4PagaJpZM4cAFjc>.

davidlange6 · 2019-03-21T13:17:59Z

ha - whoops. never mind my questions.

…

On Mar 21, 2019, at 9:15 AM, wouf ***@***.***> wrote: For why? Don't understand Your point. In this PR 10 files was changed, including 3 deletion. Отправлено с Redmi 4X David Lange ***@***.***> | От: 21 мар. 2019 г. 4:07 ПП | Сообщение: so you'll update the PR? > On Mar 21, 2019, at 8:43 AM, wouf ***@***.***> wrote: > > We needn't it anymore. I replace it with external one. I deleted pyquen.F, HepEvt.F and hepevt.inc files in this interface changes. > > why does cmssw itself need pyquen.F? > … > On Mar 21, 2019, at 5:45 AM, wouf ***@***.***> wrote: I mean that this PR should be merged simultaneously with cms-sw/cmsdist#4790 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#26226 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGIfJNS7VzkORj7sTBZOBUg0xw77_FcPks5vY4PagaJpZM4cAFjc>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

fabiocos · 2019-03-21T17:18:52Z

please test workflow 301.0 with cms-sw/cmsdist#4790

cmsbuild · 2019-03-21T17:19:19Z

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4790
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33704/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33705/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33711/console

cmsbuild · 2019-03-21T22:51:02Z

+1
Tested at: a30489f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26226/33711/summary.html

cmsbuild · 2019-03-21T22:51:09Z

Comparison job queued.

cmsbuild · 2019-03-22T00:06:46Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26226/33711/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26226/301.0_Pyquen_DiJet_pt80to120_2760GeV+Pyquen_DiJet_pt80to120_2760GeV+DIGIHIMIX+RECOHIMIX+HARVESTHI2018PPRECO

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3114829
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3114631
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

cmsbuild · 2019-03-27T09:03:07Z

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4790
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33791/console

cmsbuild · 2019-03-27T09:03:09Z

Pull request #26226 was updated. @alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please check and sign again.

cmsbuild · 2019-03-27T11:55:12Z

+1
Tested at: 8874a40
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26226/33791/summary.html

cmsbuild · 2019-03-27T11:55:22Z

Comparison job queued.

cmsbuild · 2019-03-27T13:47:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26226/33791/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26226/301.0_Pyquen_DiJet_pt80to120_2760GeV+Pyquen_DiJet_pt80to120_2760GeV+DIGIHIMIX+RECOHIMIX+HARVESTHI2018PPRECO

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3114829
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3114631
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

fabiocos · 2019-03-27T14:08:34Z

@wouf is it ok to completely remove the definition of HEPEVT COMMON size? This was just previously set to 4000 as in the external definition...

wouf · 2019-03-27T15:45:50Z

@fabiocos by default it's 4000 (I printed it like HepMC::HEPEVT_Wrapper::max_number_entries() )I'm not sure from which place this number coming from, but it looks like from SimDataFormats/GeneratorProducts
I moved manual setting HepMC::HEPEVT_Wrapper::set_max_number_entries(10000) because of decay vertex warning. I don't like this solution, because of without string HepMC::HEPEVT_Wrapper::set_max_number_entries(10000) - inconsistency HEPEVT warning is happens from time to time (it's clearly seen on 500 events). It was in old PyquenInerface too. It looks like to solve both of this issue we have to change SimDataFormats/GeneratorProducts section (data/stdhep.inc?). Please inform me if You know other solution, or can explain the connection of set_max_number_entries and vertex issue...

alberto-sanchez · 2019-04-02T01:15:13Z

@fabiocos any comment?

fabiocos · 2019-04-02T10:23:04Z

unhold

fabiocos · 2019-04-02T10:24:44Z

@alberto-sanchez @wouf as far as I understand now the COMMON size should be consistenly 4000. Error messages look gone, so I would suggest to move forward.

alberto-sanchez · 2019-04-02T12:10:47Z

+1

cmsbuild · 2019-04-02T12:11:19Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-04-02T20:42:28Z

+1

Interface for external Pyquen #4790

a30489f

cmsbuild added this to the CMSSW_10_6_X milestone Mar 20, 2019

cmsbuild added code-checks-pending comparison-pending generators-pending orp-pending pending-signatures tests-pending labels Mar 20, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 20, 2019

cmsbuild mentioned this pull request Mar 21, 2019

Pyquen reintegration as external cms-sw/cmsdist#4790

Merged

cmsbuild added requires-external tests-started and removed tests-pending labels Mar 21, 2019

cmsbuild added tests-approved and removed tests-started labels Mar 21, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 27, 2019

cmsbuild added requires-external tests-started and removed tests-pending labels Mar 27, 2019

cmsbuild added tests-approved and removed tests-started labels Mar 27, 2019

cmsbuild added comparison-available and removed comparison-pending labels Mar 27, 2019

cmsbuild removed the hold label Apr 2, 2019

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Apr 2, 2019

cmsbuild added orp-approved and removed orp-pending labels Apr 2, 2019

cmsbuild merged commit 1152681 into cms-sw:master Apr 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Interface for external Pyquen #4790 #26226

Interface for external Pyquen #4790 #26226

wouf commented Mar 20, 2019 •

edited

cmsbuild commented Mar 20, 2019

cmsbuild commented Mar 20, 2019

cmsbuild commented Mar 20, 2019

wouf commented Mar 21, 2019

davidlange6 commented Mar 21, 2019 via email

wouf commented Mar 21, 2019

davidlange6 commented Mar 21, 2019 via email

wouf commented Mar 21, 2019 via email

davidlange6 commented Mar 21, 2019 via email

fabiocos commented Mar 21, 2019

cmsbuild commented Mar 21, 2019 •

edited

cmsbuild commented Mar 21, 2019

cmsbuild commented Mar 21, 2019

cmsbuild commented Mar 22, 2019

cmsbuild commented Mar 27, 2019 •

edited

cmsbuild commented Mar 27, 2019

cmsbuild commented Mar 27, 2019

cmsbuild commented Mar 27, 2019

cmsbuild commented Mar 27, 2019

fabiocos commented Mar 27, 2019

wouf commented Mar 27, 2019

alberto-sanchez commented Apr 2, 2019

fabiocos commented Apr 2, 2019

fabiocos commented Apr 2, 2019

alberto-sanchez commented Apr 2, 2019

cmsbuild commented Apr 2, 2019

fabiocos commented Apr 2, 2019

Interface for external Pyquen #4790 #26226

Interface for external Pyquen #4790 #26226

Conversation

wouf commented Mar 20, 2019 • edited

cmsbuild commented Mar 20, 2019

cmsbuild commented Mar 20, 2019

cmsbuild commented Mar 20, 2019

wouf commented Mar 21, 2019

davidlange6 commented Mar 21, 2019 via email

wouf commented Mar 21, 2019

davidlange6 commented Mar 21, 2019 via email

wouf commented Mar 21, 2019 via email

davidlange6 commented Mar 21, 2019 via email

fabiocos commented Mar 21, 2019

cmsbuild commented Mar 21, 2019 • edited

cmsbuild commented Mar 21, 2019

cmsbuild commented Mar 21, 2019

cmsbuild commented Mar 22, 2019

cmsbuild commented Mar 27, 2019 • edited

cmsbuild commented Mar 27, 2019

cmsbuild commented Mar 27, 2019

cmsbuild commented Mar 27, 2019

cmsbuild commented Mar 27, 2019

fabiocos commented Mar 27, 2019

wouf commented Mar 27, 2019

alberto-sanchez commented Apr 2, 2019

fabiocos commented Apr 2, 2019

fabiocos commented Apr 2, 2019

alberto-sanchez commented Apr 2, 2019

cmsbuild commented Apr 2, 2019

fabiocos commented Apr 2, 2019

wouf commented Mar 20, 2019 •

edited

cmsbuild commented Mar 21, 2019 •

edited

cmsbuild commented Mar 27, 2019 •

edited