add test code for JetMETCorrections/Type1MET

[TaiSakuma]

However, all tests are commented out for now; no tests will run with scram b runtests.
I will enable them sometime in the future.

[cmsbuild]

A new Pull Request was created by @TaiSakuma (Tai Sakuma) for CMSSW_7_1_X.

add test code for JetMETCorrections/Type1MET

It involves the following packages:

JetMETCorrections/Type1MET

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2625/281/summary.html

[TaiSakuma]

@vadler, i'm trying to implement integration tests in a similar way as in PhysicsTools/PatAlgos.

The input files used in PhysicsTools/PatAlgos are present at only a couple of specific sites.
https://github.com/cms-sw/cmssw/blob/3975e7a7722629ce7620d83030f4736fc05a1315/PhysicsTools/PatAlgos/python/patInputFiles_cff.py
The test fails if it runs at a site which doesn't have the input file.

Is there a way to specify input files such that test files are (almost) always found at many different sites?

[vadler]

@TaiSakuma : The input files are RelVals, which are available, where integration tests are run (CERN and FNAL). If the tests run on LXPLUS, they are fine.
I did not x-check with the features of Data Federation (AAA) yet.

[TaiSakuma]

@vadler, I don't think that it is always true that the tests run at CERN or FNAL. I encountered one occasion where it ran at a site other than CERN or FNAL.

This test #2526 (comment) failed because it ran at one of the INFN sites which didn't have input files. Unfortunately, the test results seem to have been deleted. So I cannot show you.

[vadler]

@TaiSakuma : The INFN site was most likely xrootd.ba.infn.it, which is the regional server for Europe ( cms-xrd-global.cern.ch is the "global redirector"). However, this is about access to the input files, not about the location, where the IB tests are run.
I will try to reproduce the case and let you know about my findings...

[ktf]

This happens when the files are not found at CERN (for whatever reason)
and xrootd tries to look it up elsewhere...

On 14 Mar 2014, at 9:26, Volker Adler wrote:

@TaiSakuma : The INFN site was most likely xrootd.ba.infn.it, which
is the regional server for Europe ( cms-xrd-global.cern.ch is the
"global redirector"). However, this is about access to the input
files, not about the location, where the IB tests are run.
I will try to reproduce the case and let you know about my findings...

---

Reply to this email directly or view it on GitHub:
#2625 (comment)

[vadler]

@TaiSakuma : Both versions of `` in https://github.com/cms-sw/cmssw/pull/2625/files#diff-1 run fine for me (the third of course not; please remove it from the PR). I guess, the tests once failed due to a temporary file access issue. So, go ahead and uncomment... :-)

[TaiSakuma]

@vadler, @ktf, thank you for your comments. I updated the PR to activate the tests.

[cmsbuild]

Pull request #2625 was updated. @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please check and sign again.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2625/540/summary.html

[vadler]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?