New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HFStripFilter for Run 2 data #26251
HFStripFilter for Run 2 data #26251
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26251/8909
Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26251/8909/git-diff.patch You can run |
46dd668
to
1dd98d3
Compare
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26251/8917
|
A new Pull Request was created by @toropin for master. It involves the following packages: DataFormats/METReco @cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26251/9069
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Thank you @toropin @igv4321 @abdoulline for your updates and explanations. Ok, now it is clear to me why there can be extra HF recHits if there is a status bit newly set. It could be that the input events changed already in the baseline, and therefore it can be that the filter acting on different events give some different result. Unfortunately, the matrix logs of the IB used for the first test got erased in the meanwhile, and this cannot be checked; the changes in the next two tests reproduce as expected, instead. Just to be sure that nothing unwanted got included during the code updates that followed the review, could you please re-evaluate the performance with the latest version of this PR and confirm that they are still as expected? |
Actually after each new 'git push ...' I made full check using data file I have in my directory (events selected by JetMET group). These events are enriched with strip-like cases. |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is devoted to the development of a new filter HFStripFilter
for HF RecHits. This work was started when the JetMET group found a
lot of FakJets originated in HF. A careful examination revealed that
the high-energy hits from these jets have times ~4-6 ns and Ieta
mostly 29-34. This indicated that these hits could be the residual
tails after TDC cuts with QIE10. In Ieta 29-34 the distribution of
signals in time corresponding to early hits caused by possible PMT
hits are not well separated from the main physical signals and hits
with ~4-6 ns are probably due to tails from PMT hits (See slide 13
in ref. 1).
These early hits may be due to muons passing through "jungle" of
optical fibers coming from the HF absorbers to PMTs. In this case, we
can have a sequence of hits in one HF wedge, which can have signals in
both depths 1 and 2 and have a strip-like structure: sequence of hits
in one wedge and without or with very small signals in adjacent
wedges. Such signals cannot be marked with other HF filters, because
signals basically have comparable hits in both depths 1 and 2 and PET
and S9S1 HF filters work with hits which have very large signal in one
of depths and very small signal or no signal in another depth.
So HFStripFilter is looking for strips in HFRecHitCollection and marks
hits in the strips if they were found with special flag which could be
used for further data processing (See first part of report in ref. 2).
References:
PR validation:
The logs produced by "runTheMatrix" script look reasonable. There are few errors in log files, but one error related to data server eoscms.cern.ch which appears to be down or unreachable (cmsdev31.cern.ch). Some other workflows with errors have DAS_ERROR status which is also unrelated to this PR.
In attached Screenshots you can see pictures of EvenrDisplay (FireWorks) with HF rechits after reconstruction procedure. In column 'flags' you can see the upper 2 hits in table belonging to strip have values 1048640 (set bits 6, 20). Bit6 is new flag HcalPhase1FlagLabels::HFAnomalousHit).