Ban DQMReferenceHistogramRootFileEventSetupAnalyzer from Production DQM sequences.

[schneiml]

PR description:

The references that it loads seem to be deeply outdated, and it is a highly dangerous legacy module.

This was found as collateral damage in #26232.

PR validation:

Manual inspection of the histogram names in the old reference shows names that have not been used since 2013 (like TEC/side1, which was renamed to TEC/MINUS many years ago. Actually, I did not find any name in the reference that is still used.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26258/8931

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @schneiml (Marcel Schneider) for master.

It involves the following packages:

DQMOffline/Configuration

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33797/console Started: 2019/03/27 14:04

[cmsbuild]

+1
Tested at: 1ec760d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26258/33797/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26258/33797/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3114829
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3114631
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -25392.769 KiB( 31 files compared)
• DQMHistoSizes: changed ( 140.56 ): -3343.656 KiB Reference/Run 326479
• DQMHistoSizes: changed ( 136.85 ): -2671.211 KiB Reference/Run 315489
• DQMHistoSizes: changed ( 4.53 ): -3343.656 KiB Reference/Run 194533
• DQMHistoSizes: changed ( 4.22 ): -3339.901 KiB Reference/Run 160960
• DQMHistoSizes: changed ( 136.788 ): -2671.211 KiB Reference/Run 297557
• DQMHistoSizes: changed ( 136.731 ): -3343.656 KiB Reference/Run 274199
• DQMHistoSizes: changed ( 1000.0 ): -3339.739 KiB Reference/Run 165121
• DQMHistoSizes: changed ( 140.53 ): -3339.739 KiB Reference/Run 182124
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[schneiml]

@fabiocos @andrius-k I guess it would not hurt to get this PR into the UL 10_6 release, but it is not really needed for anything. So we can also have it wait for the next release (11?) if you prefer.

[andrius-k]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@schneiml @andrius-k do I understand correctly that these dropped references are never used in current workflows? From the PR test results it looks so

[schneiml]

@fabiocos I don't have hard evidence that they are not used anywhere, but the reference used is really old and the PR tests are fine without it, so I'd conclude that they are not used anywhere nowadays.

[fabiocos]

+1