[HGCAL trigger] Updates in SuperTCs and 3D clustering

[jbsauvan]

PR description:

Main updates:

• Add parameter to change Super trigger cells sizes + add compatibility of SuperTCs with the V9/V10 detid scheme
• Additional 3D clustering and seeding methods and parameters. And seeding and clustering methods have been split in two separate implementation classes.
• The default clustering algorithm has been changed to the newest "HistoMax" method

Additional updates:

• New L1THGCalUtilities package
  • Ntuplizers have been moved here
  • Cluster selector modules have been added
  • Python utilities to create multiple TPG chains have been added
• The dE/dX calibration has been fixed for the V9 geometry

PR validation:

Code checks and test worflows for C3, C4, and C8 geometries.

scram b code-checks
runTheMatrix.py -w upgrade -l 21234.0 --maxSteps=2
runTheMatrix.py -w upgrade -l 27434.0 --maxSteps=2
runTheMatrix.py -w upgrade -l 29034.0 --maxSteps=2

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26266/8945

• This PR adds an extra 124KB to repository

[cmsbuild]

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master.

It involves the following packages:

DataFormats/L1THGCal
L1Trigger/L1THGCal
L1Trigger/L1THGCalUtilities

The following packages do not have a category, yet:

L1Trigger/L1THGCalUtilities
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild, @rekovic, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @rovere, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[rekovic]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33818/console Started: 2019/03/28 10:42

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26266/33977/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3139747
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3139549
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[kpedro88]

@jbsauvan please make a cms-bot PR for the new package L1Trigger/L1THGCalUtilities (should go in categories l1 and upgrade)

[jbsauvan]

Done (cms-sw/cms-bot#1113)

[jbsauvan]

Hello, are there any more comments on this PR? @rekovic ?

[rekovic]

+1

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1