DD4hep: Drop Namespace in Geometry Definition #26267
Conversation
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26267/8946
|
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: DetectorDescription/DDCMS @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
-1 Tested at: 37f74e5 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test DetectorDescriptionDDCMSTestDriver had ERRORS |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison is ready Comparison Summary:
|
|
Comparison job queued. |
cmsbuild
added
comparison-pending
tests-approved
and removed
comparison-available
tests-started
labels
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 the external used has been merged, standalone tests are reported to be ok |
PR description:
Drop a namespace when building a Geometry description. This allows to drop string manipulations to retrieve copy numbers, names, etc. This gives a gain of additional 0.2 sec
PR validation:
Unit tests and integration tests run automatically.
if this PR is a backport please specify the original PR:
no back port is needed