Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GEM eMap and PF calibration in 2017 ideal simulation GT #26318

Merged
merged 1 commit into from Apr 2, 2019

Conversation

tocheng
Copy link
Contributor

@tocheng tocheng commented Apr 2, 2019

PR description:

The PR is to solve the issue Failure in wf 10424.0 due to missing GEM record by fixing the missing new GEM eMap and updating PF calibration in 2017 ideal simulation.

PR validation:

The PR is tested by running the workflow 10424 which was failed due to 2017 ideal simulation GT.
runTheMatrix -l 10424. No failure in each step.
The different in GT (see link ) is to fix the new GEMeMap missing and update PF calibration.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26318/9020

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

A new Pull Request was created by @tocheng (Tongguang) for master.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @franzoni, @tocheng can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@tocheng
Copy link
Contributor Author

tocheng commented Apr 2, 2019

@cmsbuild please test workflow 10424.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33896/console Started: 2019/04/02 11:12

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26318/33896/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26318/10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017Design_GenSimFull+DigiFull_2017Design+RecoFull_2017Design+HARVESTFull_2017Design

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3139747
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3139549
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@tocheng
Copy link
Contributor Author

tocheng commented Apr 2, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 2, 2019

+1

@cmsbuild cmsbuild merged commit cc522a0 into cms-sw:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants