Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQMIO-related tools #26337

Merged
merged 12 commits into from Apr 17, 2019
Merged

DQMIO-related tools #26337

merged 12 commits into from Apr 17, 2019

Conversation

schneiml
Copy link
Contributor

@schneiml schneiml commented Apr 3, 2019

PR description:

This PR adds some helper tools useful for DQM development:

  • root2sqlite.py is a very generic script that takes a ROOT file containing directories and/or trees and transforms the data in SQLite tables. It does not work on all root files, but, among others, DQMIO and legacy DQM output. Nontrivial queries are IMO much easier on SQLite than ROOT data...

  • dqmiodatasetharvest.py demonstrates how to read MEs from DQMIO data available via DAS. It is not supposed to be a general tool, but with minor changes it can be used for operations like historic DQM. It does exploit the fact that DQMIO data is saved per job, and therefore per-lumisection granularity data is available in prompt RECO output. It also contains code to convert the resulting file back into a TTree, but this is not done automatically.

PR validation:

No existing code is affected. The tools have proven useful in my daily work.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26337/9051

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

A new Pull Request was created by @schneiml (Marcel Schneider) for master.

It involves the following packages:

DQMServices/Components

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33932/console Started: 2019/04/03 16:09

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26337/33932/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3139747
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3139549
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 4, 2019

@schneiml these helper scripts are in principle ok to me, but I see that the print management is not python3 compatible. Could you please fix it and try to compile with python3? Otherwise this will be marked as an error in the python3 check in the IB

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26337/9278

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #26337 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 15, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34209/console Started: 2019/04/15 18:53

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26337/34209/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3142783
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3142585
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

@schneiml python3 has been enabled in the DEVEL IB for testing, otherwise for the compilation youy may use the test done on the baseline IB

https://github.com/cms-sw/cms-bot/blob/master/run-ib-python3#L13

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f117b7a into cms-sw:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants