Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HGCal] dEdx weights and thickness correction factors for V10 (D41) #26354

Merged
merged 3 commits into from
Apr 12, 2019
Merged

[HGCal] dEdx weights and thickness correction factors for V10 (D41) #26354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c406680
dEdx weights and thickness correction factors
apsallid Apr 4, 2019
8b8cdce
v9 and v10 fCperMIP are the same
apsallid Apr 11, 2019
7e0cac3
safer type for thickness corrections
apsallid Apr 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
61 changes: 59 additions & 2 deletions RecoLocalCalo/HGCalRecProducers/python/HGCalRecHit_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,63 @@


from Configuration.Eras.Modifier_phase2_hgcalV9_cff import phase2_hgcalV9
phase2_hgcalV9.toModify( dEdX, weights = dEdX_weights_v9 )
phase2_hgcalV9.toModify( dEdX, weights = dEdX_weights_v9 )

dEdX_weights_v10 = cms.vdouble(0.0, # there is no layer zero
8.894541, # Mev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't there a place in the DB for things like this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no HGCal DB yet. This has been an outstanding issue for years, and probably will continue to be.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • does it mean there is no plan to keep HGCAL conditions data in DB?
  • or does it mean that getting data to the DB is so complicated that it's easier to embed all variants of it into the CMSSW release?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure there is a plan to keep HGCal conditions in the DB on the scale of the installation timeline. But in general, at least in my experience, setting up and maintaining DB objects is quite person- and time-intensive. I am not sure there is any existing effort in the DPG devoted to this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slava77
it is very clear to the DPG that the most appropriate (only?) way to take care of these calibration constants is via the EventSetup+DB. On the other hand the current situation is still quite fluid and we prefer to have it fixed and available quickly rathter than going through the cumbersome procedure of switching to the DB. Needless to say this switch will come, but I do not have, as of today, a timescale.

10.937907,
10.937907,
10.937907,
10.937907,
10.937907,
10.937907,
10.937907,
10.937907,
10.932882,
10.932882,
10.937907,
10.937907,
10.938169,
10.938169,
10.938169,
10.938169,
10.938169,
10.938169,
10.938169,
10.938169,
10.938169,
10.938169,
10.938169,
10.938169,
10.938169,
10.938169,
32.332097,
51.574301,
51.444192,
51.444192,
51.444192,
51.444192,
51.444192,
51.444192,
51.444192,
51.444192,
51.444192,
51.444192,
69.513118,
87.582044,
87.582044,
87.582044,
87.582044,
87.582044,
87.214571,
86.888309,
86.929520,
86.929520,
86.929520)


from Configuration.Eras.Modifier_phase2_hgcalV10_cff import phase2_hgcalV10
phase2_hgcalV10.toModify( dEdX, weights = dEdX_weights_v10 )

# HGCAL rechit producer
HGCalRecHit = cms.EDProducer(
Expand Down Expand Up @@ -154,4 +210,5 @@

)

phase2_hgcalV9.toModify( HGCalRecHit , thicknessCorrection = cms.vdouble(0.759,0.760,0.773) ) #120um, 200um, 300um
phase2_hgcalV9.toModify( HGCalRecHit , thicknessCorrection = [0.759,0.760,0.773] ) #120um, 200um, 300um
phase2_hgcalV10.toModify( HGCalRecHit , thicknessCorrection = [0.781,0.775,0.769] ) #120um, 200um, 300um
11 changes: 10 additions & 1 deletion RecoLocalCalo/HGCalRecProducers/python/HGCalUncalibRecHit_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

fCPerMIP_v9 = cms.vdouble(2.06,3.43,5.15) #120um, 200um, 300um

fCPerMIP_v10 = fCPerMIP_v9

# HGCAL producer of rechits starting from digis
HGCalUncalibRecHit = cms.EDProducer(
"HGCalUncalibRecHitProducer",
Expand Down Expand Up @@ -52,4 +54,11 @@

from Configuration.Eras.Modifier_phase2_hgcalV9_cff import phase2_hgcalV9
phase2_hgcalV9.toModify( HGCalUncalibRecHit.HGCEEConfig , fCPerMIP = fCPerMIP_v9 )
phase2_hgcalV9.toModify( HGCalUncalibRecHit.HGCHEFConfig , fCPerMIP = fCPerMIP_v9 )
phase2_hgcalV9.toModify( HGCalUncalibRecHit.HGCHEFConfig , fCPerMIP = fCPerMIP_v9 )

from Configuration.Eras.Modifier_phase2_hgcalV10_cff import phase2_hgcalV10
phase2_hgcalV10.toModify( HGCalUncalibRecHit.HGCEEConfig , fCPerMIP = fCPerMIP_v10 )
phase2_hgcalV10.toModify( HGCalUncalibRecHit.HGCHEFConfig , fCPerMIP = fCPerMIP_v10 )