Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove incorrect dependencies on boost_python and an obsolete build file #26357

Merged
merged 4 commits into from Apr 9, 2019

Conversation

davidlange6
Copy link
Contributor

PR description:

direct boost_python dependencies are not needed.

PR validation:

unit tests work.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26357/9077

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

CondCore/AlignmentPlugins
CondCore/EcalPlugins
CondCore/HLTPlugins
CondCore/HcalPlugins
CondCore/PCLConfigPlugins
CondCore/RunInfoPlugins
CondCore/SiStripPlugins
PhysicsTools/SelectorUtils

@perrotta, @cmsbuild, @fwyzard, @Martin-Grunewald, @slava77, @ggovi, @santocch can you please review it and eventually sign? Thanks.
@mmusich, @argiro, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Apr 4, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33962/console Started: 2019/04/04 15:49

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26357/9078

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26357/33965/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3139747
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3139549
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Apr 4, 2019

+1

  • Technical
  • Jenkins tests pass

@santocch
Copy link

santocch commented Apr 5, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Apr 6, 2019

@ggovi @Martin-Grunewald this looks technical, please check and sign

@ggovi
Copy link
Contributor

ggovi commented Apr 9, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Apr 9, 2019

@Martin-Grunewald the only change affecting also HLT looks purely technical, I will move forward with integration. Please have a look when possible

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 9, 2019

+1

@cmsbuild cmsbuild merged commit 6386336 into cms-sw:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants