Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use python3 compatible syntax in DQMOffline packages #26364

Merged
merged 1 commit into from Apr 7, 2019

Conversation

davidlange6
Copy link
Contributor

PR description:

adapt to

  • lack of xrange function in python 3
  • keys() is now an iterator
  • integer division is //

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26364/9095

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33986/console Started: 2019/04/04 21:30

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

DQMOffline/L1Trigger
DQMOffline/Trigger

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@kreczko, @battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @thomreis, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26364/33986/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3140495
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3140297
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@andrius-k
Copy link

+1

@@ -1,14 +1,15 @@
from builtins import range
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, just out of curiosity: Why this import instead of using six.moves.range (as you've used six before)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi- I guess it was the first solution suggested by google in this case. Both solutions provide the eventual python3 behavior.

@fabiocos
Copy link
Contributor

fabiocos commented Apr 7, 2019

@rekovic please check, it looks ok to me, I will move forward with the integration for next IB

@fabiocos
Copy link
Contributor

fabiocos commented Apr 7, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Apr 7, 2019

merge

@cmsbuild cmsbuild merged commit da9934f into cms-sw:master Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants