New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use python3 compatible syntax in DQMOffline packages #26364
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26364/9095
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: DQMOffline/L1Trigger @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@@ -1,14 +1,15 @@ | |||
from builtins import range |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, just out of curiosity: Why this import instead of using six.moves.range
(as you've used six
before)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi- I guess it was the first solution suggested by google in this case. Both solutions provide the eventual python3 behavior.
@rekovic please check, it looks ok to me, I will move forward with the integration for next IB |
+1 |
merge |
PR description:
adapt to