Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add standard prod-like 2018 relvals w/ and w/o b-parking #26365

Merged
merged 2 commits into from Apr 9, 2019

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Apr 4, 2019

PR description:

This PR is to add PROD-Like RelVals for 2018, which MINIAOD is produced separately from RECO step. 2 MC relvals_standard workflows are added (w/ and w/o bParking).

Note that PROD-like wfs for 2016/2017 are not PROD-LIKE, as MINIAOD (PAT) runs in the same step as RECO,
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_steps.py#L2197-L2199

https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_standard.py#L19-L31

However, I don't touch them at this moment. This PR focus on Prod-like with bParking in 2018.

PR validation:

w/o b-parking; run out of the box

runTheMatrix.py --what standard -l 1304.18 -t 8 --noCaf --wm init

w/ b-parking; run with #26325

runTheMatrix.py --what standard -l 1304.181 -t 8 --noCaf --wm init

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26365/9102

  • This PR adds an extra 52KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2019

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @zhenhu, @prebello, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@prebello
Copy link
Contributor

prebello commented Apr 5, 2019

please test workflow 1304.18,1304.181

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33991/console Started: 2019/04/05 12:21

@srimanob
Copy link
Contributor Author

srimanob commented Apr 5, 2019

@prebello
1304.181 will fail, you need to trigger the test with #26325

@srimanob
Copy link
Contributor Author

srimanob commented Apr 5, 2019

@fabiocos
Do you want to have this in regular test? As the prod-like workflows will not produce any plot, not clear to me we should add. Thx.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2019

-1

Tested at: d410adb

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26365/33991/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

1304.181 step4
runTheMatrix-results/1304.181_ProdZEE_13UP18+ProdZEE_13UP18+DIGIUP18PROD1+RECOPRODUP18bParking+MINIAODMCUP18bParking/step4_ProdZEE_13UP18+ProdZEE_13UP18+DIGIUP18PROD1+RECOPRODUP18bParking+MINIAODMCUP18bParking.log

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2019

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@prebello
Copy link
Contributor

prebello commented Apr 5, 2019

please test workflow 1304.181 with #26325

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) #26325
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34015/console Started: 2019/04/05 22:36

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26365/34015/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26365/1304.181_ProdZEE_13UP18+ProdZEE_13UP18+DIGIUP18PROD1+RECOPRODUP18bParking+MINIAODMCUP18bParking
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26365/1304.18_ProdZEE_13UP18+ProdZEE_13UP18+DIGIUP18PROD1+RECOPRODUP18+MINIAODMCUP18

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3140495
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3140297
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Apr 7, 2019

For what I can see the test launched in #26325 using these new workflows is successful (at least it runs and I do not see complaints in the log files)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 9, 2019

@prebello @zhenhu @kpedro88 comments?

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 9, 2019

+upgrade

@zhenhu
Copy link
Contributor

zhenhu commented Apr 9, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 9, 2019

+1

@cmsbuild cmsbuild merged commit c8ada9e into cms-sw:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants