New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add standard prod-like 2018 relvals w/ and w/o b-parking #26365
add standard prod-like 2018 relvals w/ and w/o b-parking #26365
Conversation
The code-checks are being triggered in jenkins. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26365/9102
|
A new Pull Request was created by @srimanob (Phat Srimanobhas) for master. It involves the following packages: Configuration/PyReleaseValidation @cmsbuild, @zhenhu, @prebello, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 1304.18,1304.181 |
The tests are being triggered in jenkins. |
@fabiocos |
-1 Tested at: d410adb You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log1304.181 step4 runTheMatrix-results/1304.181_ProdZEE_13UP18+ProdZEE_13UP18+DIGIUP18PROD1+RECOPRODUP18bParking+MINIAODMCUP18bParking/step4_ProdZEE_13UP18+ProdZEE_13UP18+DIGIUP18PROD1+RECOPRODUP18bParking+MINIAODMCUP18bParking.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
please test workflow 1304.181 with #26325 |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
For what I can see the test launched in #26325 using these new workflows is successful (at least it runs and I do not see complaints in the log files) |
+upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is to add PROD-Like RelVals for 2018, which MINIAOD is produced separately from RECO step. 2 MC relvals_standard workflows are added (w/ and w/o bParking).
Note that PROD-like wfs for 2016/2017 are not PROD-LIKE, as MINIAOD (PAT) runs in the same step as RECO,
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_steps.py#L2197-L2199
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_standard.py#L19-L31
However, I don't touch them at this moment. This PR focus on Prod-like with bParking in 2018.
PR validation:
w/o b-parking; run out of the box
w/ b-parking; run with #26325
if this PR is a backport please specify the original PR:
Before submitting your pull requests, make sure you followed this checklist: