DD4hep: MTD Geometry Description

[ianna]

PR description:

• MTD geometry configuration and its test script
• Allow an explicit no namespace indicated as a ":" for referencing and placing the volumes
• Avoid an infinite loop when a constant cannot be resolved

PR validation:

cmsRun Geometry/MTDGeometryBuilder/test/python/testMTDGeometry.py

produces a detailed printout and a log file: mtdGeometry.log

Note: the following error is due to a missing track:DDTrackerRingAlgo algorithm implementation and should be ignored for now.

DD4CMS                 +++ Start executing algorithm DDCMS_track_DDTrackerRingAlgo....
DD4CMS           ERROR ++ FAILED  NOT ADDING SUBDETECTOR 00000000 = track:DDTrackerRingAlgo

if this PR is a backport please specify the original PR:

no back port is needed

[cmsbuild]

The code-checks are being triggered in jenkins.

[ianna]

@fabiocos - FYI, the number of other then MTD XML files is needed only due to the MTD description dependency on various constants defined elsewhere.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26371/9109

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS
Geometry/MTDCommonData
Geometry/MTDGeometryBuilder

@civanch, @Dr15Jones, @cvuosalo, @ianna, @kpedro88, @cmsbuild, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34002/console Started: 2019/04/05 16:19

[ianna]

@fabiocos, please integrate this PR before the other ones which refer to it. Thanks.

[cmsbuild]

-1

Tested at: 846d426

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26371/34002/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following workflows:
101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[ianna]

@smuzaffar and @fabiocos - the error is unrelated to this PR:

GEN,SIM,DIGI,DIGI2RAW,RAW2DIGI,L1Reco,RECO,EI,ENDJOB
We have determined that this is simulation (if not, rerun cmsDriver.py with --data)
Step: GEN Spec: 
Loading generator fragment from Configuration.Generator.SingleElectronE120EHCAL_pythia8_cfi
Step: SIM Spec: 
Step: DIGI Spec: 
Step: DIGI2RAW Spec: 
Step: RAW2DIGI Spec: 
Step: L1Reco Spec: 
Step: RECO Spec: 
Step: EI Spec: 
Step: ENDJOB Spec: 
Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/nweek-02570/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_6_X_2019-04-04-1100/bin/slc7_amd64_gcc700/cmsDriver.py", line 56, in <module>
    run()
  File "/cvmfs/cms-ib.cern.ch/nweek-02570/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_6_X_2019-04-04-1100/bin/slc7_amd64_gcc700/cmsDriver.py", line 28, in run
    configBuilder.prepare()
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-04-04-2300/python/Configuration/Applications/ConfigBuilder.py", line 2251, in prepare
    self.pythonCfgCode += self.addCustomise()
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-04-04-2300/python/Configuration/Applications/ConfigBuilder.py", line 860, in addCustomise
    raise Exception("cannot specify twice "+fcn+" as a customisation method") 
Exception: cannot specify twice customise as a customisation method

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34022/console Started: 2019/04/06 09:47
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34033/console Started: 2019/04/06 10:16

[cmsbuild]

+1
Tested at: 846d426
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26371/34033/summary.html

[cmsbuild]

Comparison job queued.

[ianna]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26371/34033/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3140495
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3140297
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

@ianna could you please elaborate on the location of the new xml MTD test geometry? All the others are under DDCMS so far...

[ianna]

@fabiocos - as we are going to production I'd rather have DPG code and configurations in their usual location rather then under DetectorDescription. The MTD xml configuration in dd4hep directory is all you need to build the MTD reco geometry and numbering and the test python configuration is ready to be included in removal validation for this package if you choose to do so.

[fabiocos]

@kpedro88 comments? Or can we move forward? I interpret the move in MTDCommonData as an as an example on top of which to further develop

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1