fix fillDescr config of PFRecoTauChargedHadronProducer

[swozniewski]

Adresses issue raised in PR #26254 concerning VPSets in PFRecoTauChargedHadronProducer.
Adds default VPSets to PFRecoTauChargedHadronProducer fillDescription.
Renames old cfi to cff and clones new auto-generated cfi.
@perrotta

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26372/9110

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @swozniewski for master.

It involves the following packages:

RecoTauTag/Configuration
RecoTauTag/RecoTau

@cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34008/console Started: 2019/04/05 17:23

[cmsbuild]

-1

Tested at: 90f531b

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ad48eeb
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26372/34008/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26372/34008/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26372/34008/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following workflows:
101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ad48eeb
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26372/34008/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26372/34008/git-merge-result

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34019/console Started: 2019/04/05 22:39

[cmsbuild]

+1
Tested at: 90f531b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26372/34019/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ad48eeb
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26372/34019/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26372/34019/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26372/34019/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3140495
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3140297
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[perrotta]

+1

• Configuration of PFRecoTauChargedHadronProducer adjusted in the fillDescription method
• The VPset's reported missing in Fix configurations and their descriptions in recoTau #26254 (comment) are now present in the generated cfi file
• Jenkins tests pass with no differences, as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1