New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add clang-format file to CMSSW #26397
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26397/9157
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: .clang-format @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: c108f34 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: AddOn
I found errors in the following addon tests: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@davidlange6 @smuzaffar as we are not enforcing yet clang-format, the addition of the agreed instruction should be ineffective, and the failure in the addOn test unrelated. I am rerunning the tests, and for instance fastsim1 now succeed. I agree in merging this PR to let the migration work start |
please test |
The tests are being triggered in jenkins. |
a standalone run of addOn tests is ok. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@Dr15Jones @smuzaffar is this finally ok for you? |
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
adds .clang-format to CMSSW (see #26082 for some history)
PR validation:
has no effect yet.