HCAL updates for phase 1 HB digis

[DryRun]

PR description:

This PR contains two changes needed to unpack and use digis from phase 1 HB:

• In HcalUnpacker, add flavor==3 condition to unpack phase 1 HB digis along with existing phase 1 HE digis.
• In QIE11DataFrame, add bit logic for phase 1 HB digis, which is different from HE.

PR validation:

• Successfully use phase 1 HB digis in online DQM for runs 328788 and 328903, with upgraded HBM10 and HBM11 included in run.
  • ADC, TDC, SOI, and capID bits work as expected.
  • Link error bits not checked.
• ./runTheMatrix.py -l 11624.0 -j4 passes with no errors.

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

@jmmans @abdoulline @mariadalfonso @arapyan @kpedro88

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26403/9162

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @DryRun (David Yu) for master.

It involves the following packages:

DataFormats/HcalDigi
EventFilter/HcalRawToDigi

@cmsbuild, @perrotta, @civanch, @mdhildreth, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @mariadalfonso, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[abdoulline]

Just would like to add:

• no changes observed in 0PU MC sanity checks (Run2/2018/Run3);
• no changes expected in any MC workflow;
• no changes expected in <= 2018 data workflows.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34076/console Started: 2019/04/09 14:37

[cmsbuild]

+1
Tested at: e663d16
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26403/34076/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26403/34076/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3140495
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3140297
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[civanch]

+1

[abdoulline]

We may need to consider back-porting it to 10_5_X, if the latter will be used for Global runs in May.
To have DQM functional for newly installed several Phase 1 HB modules.

[boudoul]

Hi @abdoulline , thanks and noted- For the release to be used, I'm collecting the needs and then we can decide with @fabiocos the best strategy in terms of release to be used for the next MWGR - Using 10_6 is not ruled out , but let's see within the next couple of weeks.

[perrotta]

+1

• Changes for Phase1 HB integrated in the code as described
• Jenkins tests pass and show no differences for the standard workflows

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[DryRun]

@abdoulline @boudoul - I'll setup the 10_5 backport now, so we have it in case of future need.

[fabiocos]

+1