Run2-TB35 Update the packages for code format an correct TB geometry for scenario 1 of Oct 18 HGCal TB #26442
Conversation
…io 1 of October TB
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26442/9237
|
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
The tests are being triggered in jenkins. |
|
Pull request #26442 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again. |
| int ncol = (int)(2.0 * rout / waferW) + 1; | ||
| int nrow = (int)(rout / (waferW * tan(30.0 * CLHEP::deg))) + 1; | ||
| int nrow = (int)(rout / (waferW * tan(30._deg))) + 1; |
There was a problem hiding this comment.
In a later PR, it would be good to turn cos(30) and tan(30) into constants.
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
@kpedro88 Please approve |
|
+upgrade |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Apply clang tidy command and also correct the October TB description
PR validation:
Tried out simulation code for generating events with this setup and also got the overlap checked
if this PR is a backport please specify the original PR:
No backport is needed