Make ESInputTag constructors explicit #26467
Conversation
Motivation comes from EventSetup-consumes. With implicit constructors it would be very easy to pass the old-style string for data label to ES-consumes() call leading to the string passed to the constructor taking the encoded value, and the string being interpreted as module label (with empty data label).
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26467/9300
|
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: FWCore/Utilities @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
tests-started
and removed
core-pending
pending-signatures
tests-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
-1 Tested at: e02b470 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
PR description:
This PR makes the
ESInputTagconstructorsexplicit. The motivation comes from EventSetup-consumes. With implicit constructors it would be very easy to pass the old-style string for data label to ES-consumes() call leading to the string passed to the constructor taking the encoded value, and the string being interpreted as module label (with empty data label).PR validation:
Framework code compiles and unit tests run successfully.