Remove PixelMatchStartLayers class and correct GsfElectronTools namespace to lower case

[guitargeek]

PR description:

Little cleanup proposal in EgammaElectronAlgos: removing the PixelMatchStartLayers class as it's slightly superfluous. I also take this opportunity to correct a namespace name which I some time ago mistakenly defined as upper case: GsfElectronToos to gsfElectronTools.

PR validation:

Compiles and matrix tests pass.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26487/9342

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaElectronProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jainshilpi, @Sam-Harper, @varuns23, @rovere, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34260/console Started: 2019/04/17 20:06

[Sam-Harper]

Thanks Jonas. One thing though, can we hold this till #26485 (or similar) is in. It should merge fine but as it touches the same files, I always get nervous.

[guitargeek]

That's right, sorry! Of course there is no rush with the cleanup PRs.

[cmsbuild]

+1
Tested at: f1ff948
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26487/34260/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26487/34260/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3142783
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3142585
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[guitargeek]

Hi @slava77, this one can be signed off now when you're ready, as Sam's remaining PR #26486 does not touch the same files anymore.

[perrotta]

+1

• Cleanup implemented as planned
• Jenkins tests pass and show no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1