-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused DQMStore pointers #26495
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26495/9351
|
A new Pull Request was created by @schneiml (Marcel Schneider) for master. It involves the following packages: CalibTracker/SiStripChannelGain @andrius-k, @kmaeshima, @christopheralanwest, @schneiml, @tocheng, @cmsbuild, @franzoni, @jfernan2, @fioriNTU, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR removes
DQMStore
member variables that are not used for anything.These are likely residues from the "threaded migration" and where used in the past, but forgotten to remove once the last usages disappeared.
PR validation:
Manual review. The changes where machine-generated and manually adapted, behavior should not change.