Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused DQMStore pointers #26495

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

schneiml
Copy link
Contributor

PR description:

This PR removes DQMStore member variables that are not used for anything.
These are likely residues from the "threaded migration" and where used in the past, but forgotten to remove once the last usages disappeared.

PR validation:

Manual review. The changes where machine-generated and manually adapted, behavior should not change.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26495/9351

  • This PR adds an extra 80KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @schneiml (Marcel Schneider) for master.

It involves the following packages:

CalibTracker/SiStripChannelGain
DQM/Physics
DQM/SiStripCommissioningClients
DQM/SiStripMonitorCluster
DQM/SiStripMonitorHardware
DQMOffline/EGamma
DQMOffline/Muon
DQMServices/Components
HLTriggerOffline/HeavyFlavor
Validation/EcalDigis
Validation/MuonIsolation

@andrius-k, @kmaeshima, @christopheralanwest, @schneiml, @tocheng, @cmsbuild, @franzoni, @jfernan2, @fioriNTU, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@erikbutz, @rappoccio, @echabert, @pieterdavid, @argiro, @fioriNTU, @threus, @hdelanno, @battibass, @jhgoh, @HuguesBrun, @ptcox, @trocino, @rociovilar, @abbiendi, @barvic, @rovere, @bellan, @tocheng, @jandrea, @alesaggio, @idebruyn, @mmusich, @mtosi, @gbenelli, @calderona, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@pohsun
Copy link

pohsun commented Apr 18, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 18, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34270/console Started: 2019/04/18 11:01

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@pohsun
Copy link

pohsun commented Apr 18, 2019

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26495/34270/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3142783
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3142585
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4fedb09 into cms-sw:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants