Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernized DTBtiChip used in L1 #26512

Merged
merged 2 commits into from
Apr 25, 2019
Merged

Modernized DTBtiChip used in L1 #26512

merged 2 commits into from
Apr 25, 2019

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • Use std::unique_ptr to manage memory
  • Switched to std::array
  • Switched to range based for loops
  • Fixed a clang warning

PR validation:

The code compiles without warnings under clang.

@Dr15Jones
Removed incorrect check on pointer before delete in DTBtiChip
cca5950 
The code was checking the address of the iterator on the stack,
not the address of the actual pointer to be deleted. Regardless,
delete works fine with a nullptr anyway.
This fixed a clang warning.
@Dr15Jones
Modernized DTBtiChip
d76822d 
-Use std::unique_ptr to manage memory
-Switched to std::array
-Switched to range based for loops
@cmsbuild cmsbuild added this to the CMSSW_10_6_X milestone Apr 23, 2019
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26512/9375

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

L1Trigger/DTBti

@cmsbuild, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 23, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34303/console Started: 2019/04/23 19:27

@cmsbuild
Copy link
Contributor

+1
Tested at: d76822d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26512/34303/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26512/34303/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Apr 24, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 447f1f2 into cms-sw:master Apr 25, 2019
@Dr15Jones Dr15Jones deleted the clangDTBtiChip branch April 26, 2019 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed l1-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_6_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @rekovic @kpedro88