Remove infinite recursion in operator<< for FSimVertex #26515

Dr15Jones · 2019-04-23T17:51:42Z

PR description:

This fixes a clang warning.

PR validation:

The code compiles using clang with no warnings.

This fixes a clang warning.

cmsbuild · 2019-04-23T17:52:11Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-04-23T17:56:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26515/9378

This PR adds an extra 12KB to repository

cmsbuild · 2019-04-23T17:57:28Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FastSimulation/Event

@cmsbuild, @ssekmen, @lveldere, @mdhildreth, @civanch can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2019-04-23T20:06:14Z

please test

cmsbuild · 2019-04-23T20:06:44Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34307/console Started: 2019/04/23 22:09

cmsbuild · 2019-04-23T21:46:31Z

-1

Tested at: 881679d

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26515/34307/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following workflows:
4.22 step4

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step4_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake2 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Tue Apr 23 23:28:08 2019-date Tue Apr 23 23:18:13 2019 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-04-23-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Apr 23 23:28:08 2019-date Tue Apr 23 23:18:13 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Tue Apr 23 23:28:08 2019-date Tue Apr 23 23:18:13 2019 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PRef --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PRef_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Tue Apr 23 23:25:29 2019-date Tue Apr 23 23:18:18 2019 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-04-23-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Apr 23 23:25:29 2019-date Tue Apr 23 23:18:18 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Tue Apr 23 23:25:29 2019-date Tue Apr 23 23:18:18 2019 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PIon --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PIon_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Tue Apr 23 23:25:28 2019-date Tue Apr 23 23:18:38 2019 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-04-23-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Apr 23 23:25:28 2019-date Tue Apr 23 23:18:38 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Tue Apr 23 23:25:28 2019-date Tue Apr 23 23:18:38 2019 s - exit: 21504
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-04-23-1100/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py : FAILED - time: date Tue Apr 23 23:22:30 2019-date Tue Apr 23 23:18:51 2019 s - exit: 23552
cmsDriver.py RelVal -s L1REPACK:GT1 --data --scenario=pp -n 10 --conditions auto:run1_hlt_Fake --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_DATA.root --filein /store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root : FAILED - time: date Tue Apr 23 23:25:25 2019-date Tue Apr 23 23:18:56 2019 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-04-23-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Apr 23 23:25:25 2019-date Tue Apr 23 23:18:56 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Tue Apr 23 23:25:25 2019-date Tue Apr 23 23:18:56 2019 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --fileout file:RelVal_Raw_GRun_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Tue Apr 23 23:29:09 2019-date Tue Apr 23 23:22:38 2019 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-04-23-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Apr 23 23:29:09 2019-date Tue Apr 23 23:22:38 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Tue Apr 23 23:29:09 2019-date Tue Apr 23 23:22:38 2019 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:GCTGT --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake1 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_DATA.root --filein /store/data/Run2015D/MuonEG/RAW/v1/000/256/677/00000/80950A90-745D-E511-92FD-02163E011C5D.root : FAILED - time: date Tue Apr 23 23:27:29 2019-date Tue Apr 23 23:24:41 2019 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2019-04-23-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Apr 23 23:27:29 2019-date Tue Apr 23 23:24:41 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Tue Apr 23 23:27:29 2019-date Tue Apr 23 23:24:41 2019 s - exit: 21504

cmsbuild · 2019-04-23T21:46:35Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

Dr15Jones · 2019-04-24T11:27:21Z

Please test

cmsbuild · 2019-04-24T11:40:18Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34318/console Started: 2019/04/24 14:16

cmsbuild · 2019-04-24T16:25:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26515/34318/summary.html

There are some workflows for which there are errors in the baseline:
1001.0 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

You potentially added 535 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3211870
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3211665
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 130 log files, 14 edm output root files, 32 DQM output files

fabiocos · 2019-04-27T08:01:55Z

please test

the comparison failure is likely due to the IB perturbation

cmsbuild · 2019-04-27T08:02:23Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34383/console Started: 2019/04/27 10:03

cmsbuild · 2019-04-27T10:13:23Z

+1
Tested at: 881679d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26515/34383/summary.html

cmsbuild · 2019-04-27T10:13:28Z

Comparison job queued.

cmsbuild · 2019-04-27T11:52:28Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26515/34383/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3211964
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3211759
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

fabiocos · 2019-04-27T14:12:12Z

+1

fabiocos · 2019-04-27T14:12:28Z

merge

@ssekmen please have a look

ssekmen · 2019-04-29T00:12:38Z

+1

cmsbuild · 2019-04-29T00:13:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Remove infinite recursion in operator<< for FSimVertex

881679d

This fixes a clang warning.

cmsbuild added this to the CMSSW_10_6_X milestone Apr 23, 2019

cmsbuild added code-checks-pending comparison-pending fastsim-pending orp-pending pending-signatures tests-pending labels Apr 23, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 23, 2019

cmsbuild added tests-started and removed tests-pending labels Apr 23, 2019

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Apr 23, 2019

cmsbuild removed the comparison-notrun label Apr 24, 2019

cmsbuild added comparison-pending tests-pending and removed tests-rejected tests-pending labels Apr 24, 2019

cmsbuild added comparison-available and removed comparison-pending labels Apr 24, 2019

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Apr 27, 2019

cmsbuild added tests-started and removed tests-pending labels Apr 27, 2019

cmsbuild added tests-approved and removed tests-started labels Apr 27, 2019

cmsbuild added comparison-available and removed comparison-pending labels Apr 27, 2019

cmsbuild added orp-approved and removed orp-pending labels Apr 27, 2019

cmsbuild merged commit 167089b into cms-sw:master Apr 27, 2019

cmsbuild added fastsim-approved fully-signed and removed fastsim-pending pending-signatures labels Apr 29, 2019

Dr15Jones deleted the clangFSimVertex branch April 30, 2019 18:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove infinite recursion in operator<< for FSimVertex #26515

Remove infinite recursion in operator<< for FSimVertex #26515

Dr15Jones commented Apr 23, 2019

cmsbuild commented Apr 23, 2019

cmsbuild commented Apr 23, 2019

cmsbuild commented Apr 23, 2019

Dr15Jones commented Apr 23, 2019

cmsbuild commented Apr 23, 2019 •

edited

cmsbuild commented Apr 23, 2019

cmsbuild commented Apr 23, 2019

Dr15Jones commented Apr 24, 2019

cmsbuild commented Apr 24, 2019 •

edited

cmsbuild commented Apr 24, 2019

fabiocos commented Apr 27, 2019

cmsbuild commented Apr 27, 2019 •

edited

cmsbuild commented Apr 27, 2019

cmsbuild commented Apr 27, 2019

cmsbuild commented Apr 27, 2019

fabiocos commented Apr 27, 2019

fabiocos commented Apr 27, 2019

ssekmen commented Apr 29, 2019

cmsbuild commented Apr 29, 2019

Remove infinite recursion in operator<< for FSimVertex #26515

Remove infinite recursion in operator<< for FSimVertex #26515

Conversation

Dr15Jones commented Apr 23, 2019

PR description:

PR validation:

cmsbuild commented Apr 23, 2019

cmsbuild commented Apr 23, 2019

cmsbuild commented Apr 23, 2019

Dr15Jones commented Apr 23, 2019

cmsbuild commented Apr 23, 2019 • edited

cmsbuild commented Apr 23, 2019

cmsbuild commented Apr 23, 2019

Dr15Jones commented Apr 24, 2019

cmsbuild commented Apr 24, 2019 • edited

cmsbuild commented Apr 24, 2019

fabiocos commented Apr 27, 2019

cmsbuild commented Apr 27, 2019 • edited

cmsbuild commented Apr 27, 2019

cmsbuild commented Apr 27, 2019

cmsbuild commented Apr 27, 2019

fabiocos commented Apr 27, 2019

fabiocos commented Apr 27, 2019

ssekmen commented Apr 29, 2019

cmsbuild commented Apr 29, 2019

cmsbuild commented Apr 23, 2019 •

edited

cmsbuild commented Apr 24, 2019 •

edited

cmsbuild commented Apr 27, 2019 •

edited