ECAL : management of PF RecHits Thresholds and Laser Alphas parameters

[depasse]

PR description:

To obtain sqlite_files of Particle Flow RecHits thresholds with different conditions and from txt files (easy to configure). To obtain sqlite files from experimental measurements of Laser Alphas (in txt format).

PR validation:

Successful cmsRun Tests with python files and txt files EB_thresholds_-1.txt, EE_thresholds_-1.txt, LaserLossRing.txt :
CondTools/Ecal/python/copyEcalPFRecHitThresholdsFromFile_cfg.py
CondTools/Ecal/test/alpha/create_alpha_trivial_byLaser_v6.py

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26522/9395

• This PR adds an extra 216KB to repository

[cmsbuild]

A new Pull Request was created by @depasse for master.

It involves the following packages:

CalibCalorimetry/EcalTrivialCondModules
CondTools/Ecal

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[tocheng]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34325/console Started: 2019/04/24 17:16

[cmsbuild]

-1

Tested at: 7fd7410

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26522/34325/summary.html

I found follow errors while testing this PR

Failed tests: ClangBuild

• Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26522/9659

• This PR adds an extra 48KB to repository

[cmsbuild]

Pull request #26522 was updated. @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @ggovi, @pohsun can you please check and sign again.

[fabiocos]

@depasse thank you, much better now. @tocheng @christopheralanwest @ggovi As far as I am concerned this PR is ready to go after the routine test

[fabiocos]

unhold

[fabiocos]

please test with cms-sw/cmsdist#4934, cms-data/CalibCalorimetry-EcalTrivialCondModules#5

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#4934,cms-data/CalibCalorimetry-EcalTrivialCondModules#5
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/67/console Started: 2019/05/08 11:24

[cmsbuild]

+1
Tested at: 3d54467
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-892fd3/67/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-892fd3/67/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[fabiocos]

@tocheng @christopheralanwest @pohsun @ggovi the changes after your signatures are just moving data files from CMSSW (and this PR) to the external data package, see cms-data/CalibCalorimetry-EcalTrivialCondModules#5

Unless you have comments by tomorrow, I will move forward with merging both this package and the corresponding external

[fabiocos]

+1

[fabiocos]

merge

@tocheng @christopheralanwest @ggovi as anticipated I move forward with the integration, please sign it for future reference

[christopheralanwest]

+1