-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Digi step to Tasks #26539
Migrate Digi step to Tasks #26539
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26539/9426
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: Configuration/StandardSequences @perrotta, @civanch, @mdhildreth, @cmsbuild, @franzoni, @kpedro88, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@makortel will this have an effect without changing the actual digi workflows to use unscheduled mode? |
@kpedro88 Yes, it has effect. With "unscheduled mode" you probably refer to The issue #26517 gives further pointers why |
@makortel thanks for the clarification |
+upgrade |
+1 |
+1
|
+operations the update of the StandardSequences is coherent with the purpose of the PR |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR migrates the Digi step and also the
DataMixerPreMix_cff
(as it is closely related to Digi step) to use Tasks in the configuration. This change should increase the available concurrency in the jobs running the Digi step.PR validation:
Limited matrix runs.