Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Digi step to Tasks #26539

Merged
merged 2 commits into from
Apr 27, 2019
Merged

Migrate Digi step to Tasks #26539

merged 2 commits into from
Apr 27, 2019

Conversation

makortel
Copy link
Contributor

PR description:

This PR migrates the Digi step and also the DataMixerPreMix_cff (as it is closely related to Digi step) to use Tasks in the configuration. This change should increase the available concurrency in the jobs running the Digi step.

PR validation:

Limited matrix runs.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26539/9426

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Configuration/StandardSequences
RecoJets/Configuration
RecoMET/Configuration
SimCalorimetry/Configuration
SimMuon/Configuration
SimMuon/GEMDigitizer

@perrotta, @civanch, @mdhildreth, @cmsbuild, @franzoni, @kpedro88, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @felicepantaleo, @abbiendi, @rappoccio, @Martin-Grunewald, @seemasharmafnal, @mmarionncern, @battibass, @ahinzmann, @jhgoh, @jdolen, @HuguesBrun, @drkovalskyi, @dildick, @trocino, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @dgulhan, @clelange, @calderona, @mariadalfonso, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 25, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34349/console Started: 2019/04/25 21:07

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26539/34349/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@kpedro88
Copy link
Contributor

@makortel will this have an effect without changing the actual digi workflows to use unscheduled mode?

@makortel
Copy link
Contributor Author

@kpedro88 Yes, it has effect. With "unscheduled mode" you probably refer to --runUnscheduled option to cmsDriver.py, right? The only effect of that option is an addition of convertToUnscneduled() customize function, which moves all EDProducers from Paths to Tasks (and associates those Tasks with the original Paths). Internally the framework has been unscheduled-only for a long time already.

The issue #26517 gives further pointers why --runUnscheduled can't be universally applied to jobs with DIGI step.

@kpedro88
Copy link
Contributor

@makortel thanks for the clarification

@kpedro88
Copy link
Contributor

+upgrade

@civanch
Copy link
Contributor

civanch commented Apr 26, 2019

+1

@perrotta
Copy link
Contributor

+1

  • Technical: migration from Sequences to Tasks is implemented as proposed in the PR description
  • Jet and MET touched for reco
  • Jenkins tests pass and show no differences

@fabiocos
Copy link
Contributor

+operations

the update of the StandardSequences is coherent with the purpose of the PR

@fabiocos
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 3403877 into cms-sw:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants