-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce fast conversion of SIPixelQuality into SiPixelFEDChannelContainer payloads #26560
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26560/9463
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CondFormats/SiPixelObjects @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@ggovi please sign off the PR when you have time. Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR introduces a module to perform fast conversion from
SiPixelQuality
payload toSiPixelFEDChannelContainer
via direct query of the Database (without passing from Event Setup).This speeds up significantly the workflow for creating conditions for so-called Stuck-TBM simulation.
PR validation:
This is a standalone module, and has been tested by running the example configuration file in
CondFormats/SiPixelObjects/test/FastSiPixelFEDChannelContainerFromQuality_cfg.py
if this PR is a backport please specify the original PR:
This is not a backport.