-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing includes for HcalDepthEnergyFractions.h #26569
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26569/9483
|
A new Pull Request was created by @slava77 (Slava Krutelyov) for master. It involves the following packages: DataFormats/PatCandidates @perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Hmm. Thank you. @slava77 Why didn't I catch it when I created this file? (so that I can avoid the same issue in future.) |
it looks like there was a (mis)configuration issue in the header checking setup, which skipped new files. So, this issue did not show up in the tests of #26465 |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
ok. i see. thank you for fixing this. |
+1 |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
Recent header consistency checks showed that there is a problem with the DataFormats/PatCandidates/interface/HcalDepthEnergyFractions.h file
This PR should fix that.