Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing includes for HcalDepthEnergyFractions.h #26569

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Apr 29, 2019

Recent header consistency checks showed that there is a problem with the DataFormats/PatCandidates/interface/HcalDepthEnergyFractions.h file

This PR should fix that.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26569/9483

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

DataFormats/PatCandidates

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@gouskos, @hatakeyamak, @rovere, @drkovalskyi, @cbernet, @gpetruc, @peruzzim this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Apr 29, 2019

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 29, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34409/console Started: 2019/04/29 20:27

@hatakeyamak
Copy link
Contributor

Hmm. Thank you. @slava77 Why didn't I catch it when I created this file? (so that I can avoid the same issue in future.)

@slava77
Copy link
Contributor Author

slava77 commented Apr 29, 2019

it looks like there was a (mis)configuration issue in the header checking setup, which skipped new files. So, this issue did not show up in the tests of #26465

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26569/34409/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@slava77
Copy link
Contributor Author

slava77 commented Apr 29, 2019

+1

for #26569 a3f62c4

  • technical
  • jenkins tests pass
    • the header checks for HcalDepthEnergyFractions.h are now clean

@hatakeyamak
Copy link
Contributor

it looks like there was a (mis)configuration issue in the header checking setup, which skipped new files. So, this issue did not show up in the tests of #26465

ok. i see. thank you for fixing this.

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit e1b6db4 into cms-sw:master Apr 30, 2019
@santocch
Copy link

santocch commented May 2, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants