Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2017 pileup scenario for ultra-legacy using bunch-by-bunch 2017 data #26572

Merged
merged 1 commit into from May 3, 2019

Conversation

plujan
Copy link
Contributor

@plujan plujan commented Apr 29, 2019

This contains the proposed pileup scenario for the 2017 ultra-legacy generation, created using the full 2017 data distribution (with the golden JSON) on a bunch-by-bunch basis. It is currently named "2017_25ns_UltraLegacy_PoissonOOTPU".

For more details see the talk here: https://indico.cern.ch/event/815042/contributions/3406023/attachments/1834447/3004998/PileupPPD20190425.pdf

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@plujan
Copy link
Contributor Author

plujan commented Apr 29, 2019

I've also added an additional contribution to the Indico page which includes some followup plots in response to the questions raised at the meeting: https://indico.cern.ch/event/815042/contributions/3406023/attachments/1834447/3008406/PileupFollowup.pdf

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26572/9486

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @plujan (Paul Lujan) for master.

It involves the following packages:

Configuration/StandardSequences
SimGeneral/MixingModule

@civanch, @mdhildreth, @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Apr 30, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 30, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34425/console Started: 2019/04/30 17:07

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26572/34425/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@civanch
Copy link
Contributor

civanch commented May 2, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented May 3, 2019

+operations

the addition of the new scenario to the StandardSequences is correct and works (cmsDriver.py command tested)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented May 3, 2019

+1

@cmsbuild cmsbuild merged commit 1c8f167 into cms-sw:master May 3, 2019
@plujan plujan deleted the Pileup2017UL branch May 23, 2019 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants