Allow python 3 execution of test configs in FWCore/Framework #26588
Conversation
The configurations were dividing two integers. In python 2 that returned another integer, in python 3 that returned a double. Using the value in a cms.(u)int32 type then failed conversion. Now explicitly convert result to int.
|
The code-checks are being triggered in jenkins. |
|
@davidlange6 FYI |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26588/9514
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready Comparison Summary:
|
|
+1 |
PR description:
The configurations were dividing two integers. In python 2 that returned another integer, in python 3 that returned a double. Using the value in a cms.(u)int32 type then failed conversion.
Now explicitly convert result to int.
PR validation:
All tests in FWCore/Framework now pass when using python3 via CMSSW_10_6_DEVEL_X.
if this PR is a backport please specify the original PR:
Before submitting your pull requests, make sure you followed this checklist: