Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix for the reconstruction_fromReco sequences: https://github.com/cms-sw/cmssw/issues/26500 #26615

Merged
merged 2 commits into from
May 7, 2019

Conversation

Fedespring
Copy link
Contributor

PR description:

This PR follows up the #26602 (fix has been implemented). In addition to #26602 it reverts the #26501.

PR validation:

Validation of the process runTheMatrix.py -l 1102.0 has been successfully done.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26615/9566

  • This PR adds an extra 48KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2019

A new Pull Request was created by @Fedespring for master.

It involves the following packages:

Configuration/ProcessModifiers
Configuration/PyReleaseValidation
RecoLocalMuon/Configuration
RecoMuon/MuonIdentification

@perrotta, @cmsbuild, @prebello, @zhenhu, @kpedro88, @pgunnell, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@echapon, @battibass, @makortel, @folguera, @abbiendi, @jhgoh, @Martin-Grunewald, @bellan, @HuguesBrun, @drkovalskyi, @calderona, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

kpedro88 commented May 3, 2019

please test workflow 1102.0

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34479/console Started: 2019/05/03 17:51

@slava77
Copy link
Contributor

slava77 commented May 3, 2019

@Fedespring
please change the name of the PR to be somewhat self-contained (a back-reference to something else is nice to know as well, but it should be auxiliary to the somewhat self-contained description).
Thank you.

@Fedespring Fedespring changed the title Follw-up of #26602 BugFix for the reconstruction_fromReco sequences: https://github.com/cms-sw/cmssw/issues/26500 May 3, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26615/34479/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@slava77
Copy link
Contributor

slava77 commented May 6, 2019

+1

for #26615 c14dfd6

  • code changes are in line with the PR description and the follow up review
  • jenkins tests pass and comparisons with the baseline show no differences
    • as expected, ROOTFileChecks shows that the muonDTDigis and muonCSCDigis no longer appear in the RECO outputs
    • RECO from RECO step (4) in workflow 1102.0 passes

@kpedro88
Copy link
Contributor

kpedro88 commented May 7, 2019

+upgrade

@prebello
Copy link
Contributor

prebello commented May 7, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented May 7, 2019

+operations

@fabiocos
Copy link
Contributor

fabiocos commented May 7, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit e0d7bdb into cms-sw:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants