Changes from scram build format-all on FWCore #26617
Conversation
Previously, this macro name in PluginFactory duplicated a macro name in Fireworks. The macro definitions were identical before so nothing complained. The modified spacing from clang format makes them different enough that the compiler is now giving a warning.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26617/9573
|
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: FWCore/Catalog @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 90822e0 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test unitTestsGroup_d had ERRORS |
|
Comparison job queued. |
cmsbuild
added
code-checks-rejected
tests-rejected
and removed
code-checks-approved
tests-started
labels
|
Comparison is ready Comparison Summary:
|
cmsbuild
added
comparison-available
code-checks-approved
and removed
comparison-pending
code-checks-rejected
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
code-checks-pending
comparison-pending
tests-pending
and removed
code-checks-approved
comparison-available
tests-approved
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26617/9661
|
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
PR description:
The first commit includes only changes from scram build code-format-all and nothing else. This PR includes all the packages in the FWCore subsystem not previously formatted, except the Skeletons package.
There were a few addition changes that showed up in code-checks in the second commit.
I also manually added one fix in the third commit to disambiguate the name of a preprocessor macro. Previously the compiler did not complain because the definitions in FWCore and Fireworks were identical, but the spacing change introduced by clang format caused the compiler to start issuing warnings.
PR validation:
The only test I performed was checking that the revised packages compile and build.