drop provenance checks when not needed in DeepFlavourTagInfoProducer #26634
Conversation
…the negative tagging is running
|
The code-checks are being triggered in jenkins. |
|
@cmsbuild please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26634/9594
|
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @slava77 (Slava Krutelyov) for master. It involves the following packages: RecoBTag/FeatureTools @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| @@ -152,6 +152,15 @@ void DeepFlavourTagInfoProducer::produce(edm::Event& iEvent, const edm::EventSet | |||
|
|
|||
| edm::Handle<ShallowTagInfoCollection> shallow_tag_infos; | |||
| iEvent.getByToken(shallow_tag_info_token_, shallow_tag_infos); | |||
| double negative_cut = 0;//used only with flip_ | |||
| if (flip_){//FIXME: Check if can do even less often than once per event | |||
There was a problem hiding this comment.
The framework guarantees that provenance is stable over an entire Run
There was a problem hiding this comment.
nice to know.
My guess was bordering on some IOV possible boundaries.
It sounds like the beginRun can be the more safe and complete version of this code.
Thanks.
cmsbuild
added
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
do provenance check only once per collection retrieval and only when the negative tagging is running.
in a recent performance inspection the provenance check was found to dominate the CPU use in the
DeepFlavourTagInfoProducer::producecallshttps://slava77sk.web.cern.ch/slava77sk/reco/cgi-bin/igprof-navigator/CMSSW_10_6_0_pre2-sign1069.136.8311.step2.1000.pp/487
This check is used only in the analysis mode with pfNegativeDeepFlavourTagInfos.
This PR moves the check out of the loop to be done just once per event and only with the
flipflag set for running negative tagging.