[HeaderCheck][GenIfc] GeneratorInterface/EvtGenInterface

[mrodozov]

• Add dep on evtgen external
• Change header path

[mrodozov]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26652/9613

• This PR adds an extra 12KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34525/console Started: 2019/05/06 15:09

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

GeneratorInterface/EvtGenInterface

@alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 6537d44
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26652/34525/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26652/34525/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2681 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 12635
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3199125
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[qliphy]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[smuzaffar]

@qliphy, @perrozzi, @efeyazgan looks like the header file ( GeneratorInterface/EvtGenInterface/interface/EvtGenLHCInterface.h) is not used any where in cmssw. I would suggest that instead of fixing and maintaining unused code we should delete it.

[alberto-sanchez]

Indeed it is a left over of the previous implementation of EvtGen interface.
I can work on this later today.