Store L1 prefiring weights in 2016 and 2017 MINIAOD

[peruzzim]

This PR adds L1 prefiring weights to MINIAOD event content for 2016 and 2017 datasets.

A new modifier run2_L1prefiring is defined to trigger this evaluation, and added to theRun2_2016 and Run2_2017 eras.
Existing trigger modifiers are then used to customise its payload configuration, that is different for each year.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26654/9615

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @peruzzim for master.

It involves the following packages:

Configuration/Eras
PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @franzoni, @slava77, @santocch, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @Martin-Grunewald, @ahinzmann, @seemasharmafnal, @mmarionncern, @makortel, @smoortga, @acaudron, @jdolen, @drkovalskyi, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @HeinerTholen, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[peruzzim]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34528/console Started: 2019/05/06 15:45

[cmsbuild]

+1
Tested at: 9497334
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26654/34528/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26654/34528/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26654/34555/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[peruzzim]

assign xpog

for future reference

[cmsbuild]

New categories assigned: xpog

@fgolf,@peruzzim you have been requested to review this Pull request/Issue and eventually sign? Thanks

[perrotta]

@peruzzim you are filling the L1 prefiring weights in miniAOD also for real data, not only for MC.
I imagine this is not wanted: could you please check and either provide a fix or comment?

[peruzzim]

this was actually done on purpose, in order to allow for data/MC comparison of weight distributions e.g. in unprefireable events, or otherwise orthogonally selected samples

[perrotta]

+1

• L1 prefiring weights are added to the miniAOD output for 2016 and 2017 eras, both in data and simulation samples
• miniAOD size increases by some 90 B/evt (for 100 events, it depends on compression)
• Jenkins tests pass and show no changes besides this additions to the miniAOD output

[peruzzim]

+xpog

[santocch]

+1

[fabiocos]

+operations

the update of Configuration is coherent with the purpose of this PR

[fabiocos]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.