[HeaderCheck][RECO3] Cleanup headers to avoid header inconsistency errors

[smuzaffar]

• Remove obsolete header
• Deleted header which are not in use

[cmsbuild]

The code-checks are being triggered in jenkins.

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26662/9623

• This PR adds an extra 16KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34534/console Started: 2019/05/06 16:43

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

RecoEcal/EgammaClusterAlgos
RecoLocalCalo/EcalRecAlgos
RecoMuon/GlobalTrackingTools
RecoMuon/MuonIsolation
RecoPixelVertexing/PixelTriplets
RecoTauTag/TauTagTools

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @jainshilpi, @abbiendi, @argiro, @echapon, @varuns23, @dgulhan, @battibass, @makortel, @jhgoh, @lgray, @HuguesBrun, @trocino, @rociovilar, @Sam-Harper, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @ebrondol, @amagitte, @calderona, @bachtis, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 1245e76
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26662/34534/summary.html

[cmsbuild]

Comparison job queued.

[slava77]

@argiro
please check and confirm that deletion is OK.
Thank you.

[slava77]

@mbluj @steggema @swozniewski
please check and confirm that this is not needed anymore.
It looks like this was (re)added in 2013 for HLT compatibility
0f45b61#diff-b027deb3da39d07e90367d5113d72d58

[mbluj]

It indeed looks as pretty old, unused code - @veelken do you remember what the code was used for (for TaNC?) and if it can be safely removed?

[steggema]

I can confirm that this is on the list of files that we're considering for removal in an upcoming cleanup, and also that it is not used by current Tau HLT algorithms (and I don't think we intend to run Run-1 tau HLT algorithms with future CMSSW).

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26662/34534/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

+1

for #26662 1245e76

• cleanup looks reasonable
  • RecoTauTag/TauTagTools/interface/ElementsInEllipseRef.h removal is confirmed OK by tau POG (this was re-added in ~CMSSW_7_0_0_pre13 0f45b61)
  • files in RecoPixelVertexing/PixelTriplets, RecoMuon/GlobalTrackingTool, and RecoMuon/MuonIsolation were already marked for deletion
  • RecoLocalCalo/EcalRecAlgos/interface/EcalSeverityLevelService.h was meant for removal in 805ceca (2011), but apparently reappeared in one of the release updates (git attributes reappearance to about 6 commits starting with "commit was manufactured by cvs2git to create tag" e.g. 83a929a, and also appears as added in the 620pre8 snapshot commit 214ab73). It looks like something funny happened either in cvs or later in git that led to the file reappearance.
  • RecoEcal/EgammaClusterAlgos/interface/LogPositionCalc.h was initially removed in 0b62578 (in 2007) and then again in a0547fd (in 2008), but resurfaced in the "Snapshot of CMSSW_6_2_0_pre8" commit 214ab73
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1