[HeaderCheck][Reco] RecoVertex/MultiVertexFit

[mrodozov]

• Remove unused header

[mrodozov]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26667/9628

• This PR adds an extra 12KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34543/console Started: 2019/05/06 18:02

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

RecoVertex/MultiVertexFit

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

this comes with RecoVertex/MultiVertexFit/src/LinPtFinderFromAdaptiveFitter.cc
Please remove that as well.

[cmsbuild]

-1

Tested at: 2cad9ab

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26667/34543/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following workflows:
1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

The code-checks are being triggered in jenkins.

[mrodozov]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26667/9644

• This PR adds an extra 12KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/48/console Started: 2019/05/07 12:24

[cmsbuild]

Pull request #26667 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[cmsbuild]

+1
Tested at: 8fa89ee
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1b0ff/48/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1b0ff/48/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

+1

• The removed files are really obsolete: they also depend on a Vertex/LinearizationPointFinders package which does not exist in CMSSW since a while
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1