Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve integer divisions compatible with python3 syntax #26682

Merged
merged 1 commit into from
May 9, 2019

Conversation

davidlange6
Copy link
Contributor

these are the only cases I see if cf*.py files where the division behavior would otherwise change in python3 vs python2 (I'm still looking for others... and of course there are the non-cf* files)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2019

The code-checks are being triggered in jenkins.

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26682/9648

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/52/console Started: 2019/05/07 14:20

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2019

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

DQMOffline/Trigger
L1Trigger/ME0Trigger

@andrius-k, @kmaeshima, @schneiml, @kpedro88, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@jshlee, @battibass, @mtosi, @jhgoh, @Martin-Grunewald, @calderona, @HuguesBrun, @dildick, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f7361/52/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@andrius-k
Copy link

+1

@fabiocos
Copy link
Contributor

fabiocos commented May 9, 2019

@kpedro88 @rekovic this looks fairly simple and technical, I would like to move forward with it, could you please have a look?

@kpedro88
Copy link
Contributor

kpedro88 commented May 9, 2019

+upgrade

@fabiocos
Copy link
Contributor

fabiocos commented May 9, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented May 9, 2019

merge

@cmsbuild cmsbuild merged commit ae6496a into cms-sw:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants