Running code-format for simulation

[cmsbuild]

Applying code-format for CMSSW category simulation.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/188//console

cms-bot has successfully run the following:

• scram build code-checks-all
• scram build code-format-all
• scram build

Fixes the code-formats suggested by #26621 (see #26686)

[cmsbuild]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26692/9663

• This PR adds an extra 8KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/72/console Started: 2019/05/08 14:21

[cmsbuild]

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

SimCalorimetry/CastorTechTrigProducer
SimCalorimetry/EcalZeroSuppressionAlgos
SimCalorimetry/EcalZeroSuppressionProducers
SimDataFormats/SimHitMaker
SimG4Core/CheckSecondary
SimG4Core/CountProcesses
SimG4Core/KillSecondaries
SimG4Core/PrintTrackNumber
SimG4Core/SaveSimTrackAction
SimG4Core/Watcher
SimGeneral/GFlash
SimGeneral/HepPDTRecord
SimGeneral/NoiseGenerators
SimTracker/Records
SimTracker/TrackerFilters
SimTracker/VertexAssociation

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@echabert, @makortel, @pieterdavid, @GiacomoSguazzoni, @gbenelli, @rovere, @argiro, @mmusich, @prolay, @ebrondol, @VinInn, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 22aeb75
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2bf3eb/72/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2bf3eb/72/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@smuzaffar this definitely looks much better

[fabiocos]

+1