-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2 Cluster1D Visualization #26699
Conversation
The code-checks are being triggered in jenkins. |
1 similar comment
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26699/9679
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: Fireworks/Geometry @cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped) |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR validation:
Produce an updated reco geometry file to include the topology:
Then display (note, add a Phase2 Cluster1D collection from a GUI):
if this PR is a backport please specify the original PR:
if a back-port is needed, the changes do not affect anything but the event display.
![Screen Shot 2019-05-08 at 16 02 15](https://user-images.githubusercontent.com/1390682/57382251-dd24c980-71ac-11e9-938a-f303e590638e.png)