Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2 Cluster1D Visualization #26699

Merged
merged 1 commit into from
May 8, 2019
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented May 8, 2019

PR description:

  • Add a proxy builder for Phase2 Cluster1D
  • Add a proxy builder for Phase2 Cluster1D Dets
  • Store Phase2 tracker topology of a Phase2 tracker geometric DetUnit: par[0] == pitch and par[1] == length

PR validation:

Produce an updated reco geometry file to include the topology:

cmsRun Fireworks/Geometry/python/dumpRecoGeometry_cfg.py tag=2023 version=D41

Then display (note, add a Phase2 Cluster1D collection from a GUI):

cmsShow -c cluster1d.fwc -g cmsRecoGeom-2023.root step3_200.root

if this PR is a backport please specify the original PR:

if a back-port is needed, the changes do not affect anything but the event display.
Screen Shot 2019-05-08 at 16 02 15

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

The code-checks are being triggered in jenkins.

1 similar comment
@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26699/9679

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Fireworks/Geometry
Fireworks/Tracks

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ianna
Copy link
Contributor Author

ianna commented May 8, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/84/console Started: 2019/05/08 16:30

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@alja
Copy link
Contributor

alja commented May 8, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented May 8, 2019

+1

@cmsbuild cmsbuild merged commit 7d4a3c1 into cms-sw:master May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants